Skip to content

Fix up comments for super calls rewritten as returns#12197

Merged
mhegazy merged 5 commits into
masterfrom
commentsSuperCallReturns
Nov 15, 2016
Merged

Fix up comments for super calls rewritten as returns#12197
mhegazy merged 5 commits into
masterfrom
commentsSuperCallReturns

Conversation

@DanielRosenwasser
Copy link
Copy Markdown
Member

Fixes #12191.

Comment thread src/compiler/transformers/es2015.ts Outdated
const returnStatement = createReturn(superCallExpression);

if (superCallExpression.kind !== SyntaxKind.BinaryExpression
&& (superCallExpression as BinaryExpression).left.kind !== SyntaxKind.CallExpression) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you mean || here.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Nov 14, 2016

@rbuckton can you take a look.

@mhegazy mhegazy merged commit 1164df2 into master Nov 15, 2016
@mhegazy mhegazy deleted the commentsSuperCallReturns branch November 15, 2016 00:10
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants