fix #12137, correct ProxyHandler signatures#12172
Merged
Merged
Conversation
mhegazy
reviewed
Nov 11, 2016
| @@ -1,5 +1,5 @@ | |||
| interface ProxyHandler<T> { | |||
| getPrototypeOf? (target: T): any; | |||
| getPrototypeOf? (target: T): Object | null; | |||
Contributor
Author
There was a problem hiding this comment.
Done. Still I wonder whether is using {} clearer than Object? I know that these two are confusing for newcomers. But at least Object suggests non-primitive values.
Contributor
Author
|
node 4 build fails. tslint requires update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The correction is according to:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/getPrototypeOf
and
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Proxy/handler/construct
getPrototypeOftrap should return a nullableObjectandconstructshould return anObject.Though
Objectis treated as{}in TypeScript which does include primitive value, this change is enough for preventing user from forgetting to return value.