add 'installSuccess' flag to telemetry, cache misses if npm install fails#12163
Merged
Conversation
mhegazy
approved these changes
Nov 11, 2016
billti
reviewed
Nov 11, 2016
| } | ||
| for (const typing of filteredTypings) { | ||
| this.missingTypingsSet[typing] = true; | ||
| } |
Member
There was a problem hiding this comment.
It's interesting that we mark all the packages as missing. I assume that the npm install command could fail because one package failed, but the rest installed correctly? Or does NPM install in an "all-or-nothing" fashion?
Contributor
Author
There was a problem hiding this comment.
it is all or nothing
billti
reviewed
Nov 11, 2016
| // treat any output on stdout as success | ||
| onRequestCompleted(!!stdout); | ||
| // treat absence of error as success | ||
| onRequestCompleted(!err); |
Member
There was a problem hiding this comment.
I assume we've confirmed that "npm install" returns a non-0 error code across platforms/versions if a package fails to install (and always returns 0 on success, not like "1" if it succeeded with extra info).
Contributor
Author
There was a problem hiding this comment.
yes, that is correct
vladima
added a commit
that referenced
this pull request
Nov 14, 2016
…ails (#12163) * add 'installSuccess' flag to telemetry, cache misses if npm install fails * fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// cc @mhegazy, @billti