When looking up modules in @types, only look for index.d.ts and `pa…#11926
Merged
3 commits merged intoNov 11, 2016
Merged
Conversation
ghost
commented
Oct 28, 2016
| host: ModuleResolutionHost; | ||
| // We only use this subset of the compiler options. | ||
| compilerOptions: { rootDirs?: string[], baseUrl?: string, paths?: MapLike<string[]> }; | ||
| compilerOptions: CompilerOptions; |
Author
There was a problem hiding this comment.
Turns out that since CompilerOptions consists only of optional properties, anything can be assigned to it. So while I thought I was statically ensuring that these were the only compiler options used, we actually use several others, by passing this into a parameter of type CompilerOptions and then accessing them.
ghost
commented
Oct 28, 2016
| currentDirectory = host.getCurrentDirectory(); | ||
| } | ||
|
|
||
| return currentDirectory !== undefined && getDefaultTypeRoots(currentDirectory, host); |
Author
There was a problem hiding this comment.
This line actually returns string[] | false.
vladima
approved these changes
Nov 11, 2016
added 2 commits
November 11, 2016 12:49
a748444 to
823d385
Compare
Member
|
Is this just to speed resolution up? Is there an issue tracking this? |
Author
|
This is just for neatness. We shouldn't be publishing |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also makes some of the code neater.