Fix bug: We want to test for existence of the enum value, not whether it's non-zero#11893
Merged
2 commits merged intoOct 27, 2016
Merged
Fix bug: We want to test for existence of the enum value, not whether it's non-zero#118932 commits merged into
2 commits merged into
Conversation
sandersn
approved these changes
Oct 27, 2016
| if (host.resolveModuleNames) { | ||
| resolveModuleNamesWorker = (moduleNames, containingFile) => host.resolveModuleNames(moduleNames, containingFile).map(resolved => { | ||
| // An older host may have omitted extension, in which case we should infer it from the file extension of resolvedFileName. | ||
| if (!resolved || resolved.extension) { |
Member
There was a problem hiding this comment.
resolved.extension was completely backwards before then? That is, it should have been !resolved.extension to even be close to correct?
sandersn
approved these changes
Oct 27, 2016
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.