Add noop, notImplemented, and notYetImplemented helpers#11737
Merged
2 commits merged intoOct 20, 2016
Merged
Conversation
ddaf23c to
7976c80
Compare
7976c80 to
5e7e542
Compare
mhegazy
reviewed
Oct 19, 2016
| } | ||
|
|
||
| /** A function which isn't implemented, but should be eventually. */ | ||
| export function notYetImplemented(): never { |
Contributor
There was a problem hiding this comment.
i would just use notImplemented.
mhegazy
approved these changes
Oct 19, 2016
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are common patterns I noticed while looking at unused parameters.