Skip to content

Adds ES5 to ES3 transformer for reserved words#11652

Merged
rbuckton merged 2 commits into
masterfrom
transformES5
Oct 17, 2016
Merged

Adds ES5 to ES3 transformer for reserved words#11652
rbuckton merged 2 commits into
masterfrom
transformES5

Conversation

@rbuckton

Copy link
Copy Markdown
Contributor

This change adds a simple transformer to substitute ElementAccessExpression for PropertyAccessExpression and to substitute Identifier for StringLiteral in a PropertyAssignment when the property name is a reserved word.

// CC: @yuit, @vladima, @mhegazy

@mhegazy mhegazy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@mhegazy

mhegazy commented Oct 17, 2016

Copy link
Copy Markdown
Contributor

Fixes #2296

@rbuckton rbuckton merged commit 2321e28 into master Oct 17, 2016
@rbuckton rbuckton deleted the transformES5 branch October 17, 2016 23:46
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants