Avoid watching non-existing directories and fix null-exception#11601
Merged
Conversation
Contributor
|
We need to do this also for watchDirectory calls in tsc.ts. I wounder if we should instead do it in watchDirectory in sys. |
Author
|
Interestingly tsc -w doesn't have this issue. I guess the null exception might actually be the source of this particular problem, but yeah it would be worth adding the prevention anyways. |
mhegazy
approved these changes
Oct 13, 2016
Author
|
All tests passed on a local machine. As the CI takes several hours and this fix is urgent for the next release, merging it in. |
zhengbli
pushed a commit
that referenced
this pull request
Oct 13, 2016
* Avoid watching non-existing directories and fix null-exception * Add test * Move the fix to sys to cover tsc -w also
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11568