Automatically generate protocol.d.ts by pulling in necessary dependencies#11550
Merged
Conversation
Member
|
Looked at https://gist.github.com/vladima/411ec6893d4e07a08c4804afbf0d754a. Looks very nice. |
Member
|
One minor comment: this is actually breaking names: EditorOptions -> EditorSettings OK with me but you might want to doc this. |
mhegazy
reviewed
Oct 12, 2016
| command: CommandTypes.Quickinfo; | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
this should be internal too
mhegazy
reviewed
Oct 12, 2016
|
|
||
| file(buildProtocolTs); | ||
|
|
||
| compileFile(buildProtocolJs, |
Contributor
There was a problem hiding this comment.
we need to add the new file to the LKG list
mhegazy
approved these changes
Oct 12, 2016
vladima
added a commit
that referenced
this pull request
Oct 12, 2016
Automatically generate protocol.d.ts by pulling in necessary dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a result
protocol.d.tscan be compiled as a standalone file (modulolib.d.ts)Also in this PR
FileLocationRequest- we'll do work to properly split messages to line/offset-based and position-based laterExample of generated
protocol.d.ts: https://gist.github.com/vladima/411ec6893d4e07a08c4804afbf0d754apending work: reflect changes made in
Jakefile.jsingulpscriptfixes: #11520, #11519, #11518, #11516, #11515, #11514. #11482, #11487
// CC: @mhegazy, @dbaeumer