[Master] Fix 11339; using localeCompare cause exception in window 2012 dueto Intl#11541
Merged
Conversation
mhegazy
suggested changes
Oct 11, 2016
| * @param locales string of BCP 47 language tag or an array of string of BCP 47 language tag | ||
| * @param options an object of Intl.CollatorOptions to specify localeCompare properties | ||
| */ | ||
| export function localeCompare(a: string, b: string, locales?: string | string[], options?: Intl.CollatorOptions): number | undefined { |
Contributor
There was a problem hiding this comment.
I would rather we use comperStrings as the only place where we use localeCompare rather than returning undefined, and having every caller check for it
mhegazy
suggested changes
Oct 13, 2016
| } | ||
|
|
||
| export function compareStrings(a: string, b: string, ignoreCase?: boolean): Comparison { | ||
| export function compareStrings(a: string, b: string, locales?: string | string[], options?: Intl.CollatorOptions): Comparison { |
Contributor
There was a problem hiding this comment.
Do we ever use locale? If not I would remove that parameter.
Also can we just accentSensitivety everywhere? Seems the only place we do not use it is nav bar ordering, but do not think that we need to.. an I missing something?
mhegazy
approved these changes
Oct 13, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11339
@mhegazy @vladima