Remove cached resolvedModule result if the target file was deleted#11460
Merged
Conversation
Contributor
|
this is not the right fix - let's discuss it offline |
Author
|
@vladima Done updating. I'll do a squash merge after your reiview. Thanks! |
vladima
reviewed
Oct 11, 2016
| resolveModuleNames(moduleNames: string[], containingFile: string): ResolvedModule[] { | ||
| return this.resolveNamesWithLocalCache(moduleNames, containingFile, this.resolvedModuleNames, this.resolveModuleName, m => m.resolvedModule); | ||
| return this.resolveNamesWithLocalCache(moduleNames, containingFile, this.resolvedModuleNames, this.resolveModuleName, m => { | ||
| if (!m.resolvedModule) { |
Contributor
There was a problem hiding this comment.
it will be better to do the following:
- add a constraint
R extends { resolvedFileName?: string }toRtype parameter inresolveNamesWithLocalCache- bothResolvedModuleandResolvedTypeReferenceDirectivesatisfy this constraint. - inside
moduleResolutionIsValidso something like:
// lastDeletedFileName should be declared as somewhere before the `for-of` loop
// const lastDeletedFileName = this.project.projectService.lastDeletedFile && this.project.projectService.lastDeletedFile.fileName;
const result = getResult(resolution);
if (result) {
if (result.resolvedFileName && result.resolvedFileName === lastDeletedFileName) {
return false;
}
return true;
}
Author
There was a problem hiding this comment.
Great suggestion! Done updating.
vladima
approved these changes
Oct 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we cache successfully resolved module result in
SourceFileobject, even when the target file is deleted. This prevents themodule not founderror being removed if the deleted file was added back.Fixes #11206 .