You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some global symbol lookups (PromiseConstructorLike, ClassDecorator, etc.) are deferred until needed during check, but are missed by getGlobalDiagnostics and getSemanticDiagnostics when getting diagnostics for a single file.
The checks in checkAsyncFunctionReturnType was trying to report an error finding the global Promise type (lost due to [1] above) rather than reporting an error about the current return type.
I wonder if we could leverage @weswigham's Type Builder API internally to synthesize types like PromiseConstructorLike internally if they are not found, rather than reporting an error. Without such an API it is just too messy to synthesize a type.
I think it'd be a good idea. TBH just having a canonical way to
programmatically build types which is a bit closer to the syntax than the
internal type representation can be super nice.
I wonder if we could leverage @weswighamhttps://github.com/weswigham's
Type Builder API internally to synthesize types like
PromiseConstructorLike internally if they are not found, rather than
reporting an error. Without such an API it is just too messy to synthesize
a type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two issues here:
getGlobalDiagnosticsandgetSemanticDiagnosticswhen getting diagnostics for a single file.checkAsyncFunctionReturnTypewas trying to report an error finding the globalPromisetype (lost due to [1] above) rather than reporting an error about the current return type.Fixes #11376