[Release 2.0.5] Porting completion and goto def fixes#11408
Merged
Conversation
Member
sheetalkamat
commented
Oct 6, 2016
- Fix incorrect returning of completion entries when in string literal of property assignment expression Fix incorrect returning of completion entries when in string literal of property assignment expression #11401 Fixes Inappropriate string literal completions in object literals #11232
- Add missing check in javascript file for valid identifier when creating completion entry from symbol Add missing check in javascript file for valid identifier when creating completion entry from symbol #11395 Fixes Completion list showing bogus completions #11217
- Handle the require call in javascript file for getSymbolAtLocation Handle the require call in javascript file for getSymbolAtLocation #11373 This helps in getting the alias symbol so that it can go to the definition of external module Fixes Go-to-definition doesn't work on path in calls to 'require' #9251
mhegazy
approved these changes
Oct 6, 2016
This helps in getting the alias symbol so that it can go to the definition of external module Fixes #9251
5550c44 to
d8280d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.