Update browserify task for gulp-typescript 3.0#11358
Merged
Merged
Conversation
1. Doesn't need extra src/ prefix 2. testProject is now a function that needs to be called first.
Member
Author
|
Better wait on this. Sourcemaps are now broken and gulp-typescript 3.0's notes indicate there is no simple fix. So until I figure out a fix, runtests-browser starts up Chrome but doesn't have any tests available. |
ghost
approved these changes
Oct 5, 2016
ghost
left a comment
There was a problem hiding this comment.
I tested and I can open chrome and use source maps.
ghost
pushed a commit
that referenced
this pull request
Oct 12, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes runtests-browser
2a.
path.resolveapparently relies onthisbecause you can't pass it straight tomap. :(