Fix tests changed by #11309#11350
Merged
Merged
Conversation
Author
|
Tested this on a completely clean checkout and the test is failing in master, but works in this branch. Travis is probably caching the |
Contributor
|
Do not think this is needed any linger. can we close it? |
Member
|
It still fails with gulp. @Andy-MS figured out that it was a mismatch between the Gulpfile and the Jakefile, so I added the newlines to the Jakefile and it's now working. I'll push the commit with the Jakefile change to this PR. |
sandersn
approved these changes
Oct 17, 2016
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks like Travis passes now.
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: #11309