Restrict base-class-first error to class declaration bases#11349
Merged
Conversation
mhegazy
reviewed
Oct 13, 2016
| if (baseType.symbol.valueDeclaration && !isInAmbientContext(baseType.symbol.valueDeclaration)) { | ||
| if (baseType.symbol.valueDeclaration && | ||
| !isInAmbientContext(baseType.symbol.valueDeclaration) && | ||
| baseType.symbol.valueDeclaration.kind === SyntaxKind.ClassDeclaration) { |
Contributor
There was a problem hiding this comment.
what about:
class C extends makeClass() {}
var makeClass = function() {...}
Member
Author
There was a problem hiding this comment.
We don't know whether the var was meaningfully hoisted out or not
Contributor
There was a problem hiding this comment.
functions are hoisted, vars are not. so we could add another clause for functions as well. that is all what i meant.
Member
Author
There was a problem hiding this comment.
Their declarations are hoisted, which means they might be initialized earlier
makeClass = function() { ... }
class C extends makeClass() {}
var makeClass = function() {...}
Member
Author
There was a problem hiding this comment.
We could check for let / const though
Contributor
There was a problem hiding this comment.
const/let should give you an error already if used before declaration.
Contributor
There was a problem hiding this comment.
so look like it is not worth the change then.. nevermind.
mhegazy
approved these changes
Oct 19, 2016
9a917a1 to
58ed72f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes all known repros of #10624