Skip to content

do not reset current flow after processing finally block if it was unreachable#11310

Merged
vladima merged 2 commits into
masterfrom
vladima/unreachable-state-after-finally
Oct 3, 2016
Merged

do not reset current flow after processing finally block if it was unreachable#11310
vladima merged 2 commits into
masterfrom
vladima/unreachable-state-after-finally

Conversation

@vladima
Copy link
Copy Markdown
Contributor

@vladima vladima commented Oct 2, 2016

fixes #11307

@@ -0,0 +1,12 @@
function f() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noImplicitReturns: true

Copy link
Copy Markdown
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with test updates

@vladima vladima merged commit 4800464 into master Oct 3, 2016
@vladima vladima deleted the vladima/unreachable-state-after-finally branch October 3, 2016 18:03
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'finally' clause not accounted for in control flow analysis

3 participants