Use new Function-less access to this for debugObjectHost#11265
Merged
Conversation
Originally it was just `debugObjectHost = this as any`, but this breaks
--noImplicitThis. Now it's `(function () { return this })()`.
Member
Author
|
@vladima can you take a look? |
mhegazy
approved these changes
Sep 29, 2016
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a comment on the original PR #9580.
Originally it was just
debugObjectHost = this as any, but this breaks --noImplicitThis. So #9580 changed it to(new Function("return this"))(). Now it's(function () { return this })().