Skip to content

Routine update of dom libs#11164

Merged
zhengbli merged 1 commit into
microsoft:masterfrom
zhengbli:updateLib09262016
Sep 28, 2016
Merged

Routine update of dom libs#11164
zhengbli merged 1 commit into
microsoft:masterfrom
zhengbli:updateLib09262016

Conversation

@zhengbli
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhengbli zhengbli merged commit 60ab007 into microsoft:master Sep 28, 2016
@zhengbli zhengbli deleted the updateLib09262016 branch September 28, 2016 02:00
@ghost
Copy link
Copy Markdown

ghost commented Sep 28, 2016

- addEventListener(type: "error", listener: (this: this, ev: ErrorEvent) => any, useCapture?: boolean): void;

+ addEventListener(type: "error", listener: (this: this, ev: ProgressEvent) => any, useCapture?: boolean): void;

Is that right?

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Sep 28, 2016

Why not?

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Sep 28, 2016

Here is the change that brought this in: microsoft/TypeScript-DOM-lib-generator#144

@ghost
Copy link
Copy Markdown

ghost commented Sep 28, 2016

@mhegazy It just seemed odd that the event object type of the error event changed from ErrorEvent to ProgressEvent. I didn't bother checking whether or not it was actually correct.

@zhengbli
Copy link
Copy Markdown
Author

@errorx666 the spec said so: https://xhr.spec.whatwg.org/#events

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants