Fix Reflect has method signature(s) per issue #10949 initial report#10962
Conversation
Author
|
btw. I didn't push up the corresponding built lib file lib/lib.es2015.reflect.d.ts as wasn't sure whether to or not especially as it is generated in the compile process (and didn't seem to be the right thing to do). Just kept it simple for your merge as you will be recompiling anyway. |
Contributor
thanks! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10949 As per fix initially proposed when issue was created. We just delete the two 'has' methods and replace with a single 'has' method with the signature fixed with 'PropertyKey' annotation.
This brings Reflect into sync with Proxy handler methods noting that all the other methods in Reflect which accept a 'propKey' argument are already annotated with 'PropertyKey' type.
Note that ECMA-262 7th Edition has removed the 'enumerate' method from Reflect altogether yet it remains in es2015.proxy.d.ts. Whether this should be removed or not to bring 'ProxyHandler' into line with the 7th Edition or not I do not know. I don't otherwise know of any means of marking a method as "deprecated" in TypeScript (but perhaps there is?).