Fix 10843: Change Array.prototype.findIndex method definition according to ES6 spec#10917
Conversation
|
Hi @Salasar, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! The agreement was validated by Microsoft and real humans are currently evaluating your PR. TTYL, MSBOT; |
mhegazy
left a comment
There was a problem hiding this comment.
findIndex also exists in src/lib/es5.d.ts for the typed array variants. you will need to update these too.
Tests are not needed for these.
| * @param thisArg If provided, it will be used as the this value for each invocation of | ||
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: T) => boolean, thisArg?: any): number; |
There was a problem hiding this comment.
these files are generated from the build and should not be changed manually. so please remove these.
see https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md#contributing-libdts-fixes for more details.
| * predicate. If it is not provided, undefined is used instead. | ||
| */ | ||
| findIndex(predicate: (value: T) => boolean, thisArg?: any): number; | ||
| findIndex(predicate: (value: T, index: number, obj: Array<T>) => boolean, thisArg?: any): number; |
|
@mhegazy I have added necessary changes, please, check it. |
|
thanks! |
Fixes #10843 according to standart http://www.ecma-international.org/ecma-262/6.0/#sec-array.prototype.findindex