Avoid returning type symbols for js configured projects#10654
Merged
Conversation
| }); | ||
| }); | ||
|
|
||
| describe("nagivateTo for javascript project", () => { |
| }); | ||
| }); | ||
|
|
||
| describe("nagivate for javascript project", () => { |
Author
There was a problem hiding this comment.
Aha I misunderstood.
Time to find a spell check plugin ...
| hasChanges = this.updateGraphWorker() || hasChanges; | ||
| } | ||
| if (hasChanges) { | ||
| this._isJsOnlyProject = allRootFilesAreJsOrDts(this); |
Contributor
There was a problem hiding this comment.
actually after thinking about it a bit more better places to invalidate the value will be addRoot and removeRoot - there we can set this._isJsOnlyProject to undefined and compute the value on demand when it is requested
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10606