Skip to content

When emitting react code, replace HTML numeric entities with their encoded characters#10561

Closed
ghost wants to merge 3 commits into
masterfrom
react_emit_entities
Closed

When emitting react code, replace HTML numeric entities with their encoded characters#10561
ghost wants to merge 3 commits into
masterfrom
react_emit_entities

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 26, 2016

Fixes #10492
(does not fix the problem in the second comment)

Comment thread src/compiler/emitter.ts Outdated
}

/**
* Replace entities like " ", "&#123", and "&#xDEADBEEF" with the characters they encode.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second two examples are missing trailing semicolons (these are required?)

@ghost ghost assigned zhengbli Sep 6, 2016
@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 7, 2016

Closed in favor of #10747

@ghost ghost closed this Sep 7, 2016
@ghost ghost deleted the react_emit_entities branch September 7, 2016 13:36
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSX: Convert ampersand encoded HTML entities into UTF-8

3 participants