Couldn't a path ending in a slash just be a file with no name but an implied extension? Ie, foo/bar/ could be referencing /too/bar/.ts?

Node

foo/.js

module.exports = ".js"

a.js

console.log(require("./foo/"));

Result:

Error: Cannot find module './foo/'

SystemJS

SystemJS always requires an extension so there's no ambiguity there.

RequireJS

RequireJS seems to allow this:
(Basing my test on https://github.com/volojs/create-template)

main.js

requirejs(["helper/"], console.log);

helper/.js:

define(() => ".js");

Result: logs ".js"

Conclusion

We could always just take out the change here https://github.com/Microsoft/TypeScript/pull/10510/files#diff-08a3cc4f1f9a51dbb468c2810f5229d3R649 and all that would change would be traces. But then we would be allowing node users to import "foo/" matched by "foo/.ts", which would fail at runtime. On the other hand, the change makes the code more complicated and would forbid requirejs users from some valid imports.

If you configure syatemjs with the default extension option, does it behave
the same as requirejs?

Do browserify and webpack work exactly the same as Node?

On Wed, Aug 24, 2016, 9:41 AM Andy notifications@github.com wrote:

Node

foo/.js

module.exports = ".js"

a.js

console.log(require("./foo/"));

Result:

Error: Cannot find module './foo/'

SystemJS

SystemJS always requires an extension so there's no ambiguity there.
RequireJS

RequireJS seems to allow this:
(Basing my test on https://github.com/volojs/create-template)

main.js

requirejs(["helper/"], console.log);

helper/.js:

define(() => ".js");

Result: logs ".js"
Conclusion

We could always just take out the change here
https://github.com/Microsoft/TypeScript/pull/10510/files#diff-08a3cc4f1f9a51dbb468c2810f5229d3R649
and all that would change would be traces. But then we would be allowing
node users to import "foo/" matched by "foo/.ts", which would fail at
runtime. On the other hand, the change makes the code more complicated and
would forbid requirejs users from some valid imports.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10510 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACzAMg5kTbYS4of6EzrwU-_rypCmzOG3ks5qjEnrgaJpZM4JrXRZ
.

Filing a separate issue for that since it shouldn't block this: #10562

@weswigham Take a look at systemjs/systemjs#1069 and systemjs/systemjs#1308.

👍