Convert majority of enums in compiler to const enums#1049
Merged
Conversation
Contributor
|
👍 |
Contributor
|
Can you hold off on checking this in until we do the work to update the VS build. We want to make sure the compiler/LS we get there has reverse maps in debug builds. |
Contributor
Author
|
Sure |
Member
|
👍 |
Contributor
|
can you update jakeFile to use the new flag in debug as well. 👍 |
Contributor
|
lgtm 👍 |
vladima
added a commit
that referenced
this pull request
Nov 4, 2014
Convert majority of enums in compiler to const enums
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still few regular enums lurking around in services layer like
TokenClassorMatchKind- existing code uses reverse mapping. Since these enums are small - we can keep them.Diff in size between LKG (compiler that support const enums) and bootstrapped compiler (with const enums inlined) - ~46 KB