Simplifies performance API#10327
Merged
Merged
Conversation
| checkSourceFileWorker(node); | ||
|
|
||
| performance.measure("Check", start); | ||
| performance.mark("checkEnd"); |
Contributor
There was a problem hiding this comment.
question: it seems you don't have to call mark here then as the function 'measure' will call timestamp() if you don't pass the end mark anyway?
Contributor
Author
There was a problem hiding this comment.
I call mark to emit the performance event, that way I can query a cpuprofile for things like between(checkStart, checkEnd).
Contributor
|
@rbuckton look good just wonder if you could send where is ts-perf profiler is, I can't find it 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change streamlines the performance API and moves the various markers and measurements to
MapoverMapLike. As a result, some scenarios such as Angular are improved by another 3% (350ms). This change also improves integration with the ts-perf profiler, making it easier to analyze performance events.