Fix loop over array to use for-of instead of for-in#10227
Merged
Conversation
Member
|
👍 |
1 similar comment
Contributor
|
👍 |
Member
|
@Andy-MS Re: Lint rule: Seems a bit strong. I'd rather just forbid using a For the record, we use TBH, we do use the construct infrequently enough that we could just forbid |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I can't find any tests that this changes, but
listFilesreturns an array andfs.addFileexpects a path, not an array index. Why is this not getting caught by our tests?Also, @weswigham: I've been thinking we could add a lint rule where the object of a for-in loop would have to be of the
Maptype. What do you think?