Skip to content

[Release 2.0] fix10076 : Destructing with "this" #10209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuit merged 2 commits into from
Aug 9, 2016
Merged

[Release 2.0] fix10076 : Destructing with "this" #10209

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a92701
Call checkExpression eventhough there is no appropriate type from des…
Aug 8, 2016
d90c99d
Add tests and baselines
Aug 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Call checkExpression eventhough there is no appropriate type from des… 
…tructuring of array
  • Loading branch information
Kanchalai Tanglertsampan committed Aug 8, 2016
commit 5a92701749f13491e7f1a983c7bb3eaef515a632
14 changes: 11 additions & 3 deletions src/compiler/checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4308,9 +4308,14 @@ namespace ts {
return property;
}

// Return the symbol for the property with the given name in the given type. Creates synthetic union properties when
// necessary, maps primitive types and type parameters are to their apparent types, and augments with properties from
// Object and Function as appropriate.
/**
* Return the symbol for the property with the given name in the given type. Creates synthetic union properties when
* necessary, maps primitive types and type parameters are to their apparent types, and augments with properties from
* Object and Function as appropriate.
*
* @param type a type to look up property from
* @param name a name of property to look up in a given type
*/
function getPropertyOfType(type: Type, name: string): Symbol {
type = getApparentType(type);
if (type.flags & TypeFlags.ObjectType) {
Expand Down Expand Up @@ -12516,6 +12521,9 @@ namespace ts {
return checkDestructuringAssignment(element, type, contextualMapper);
}
else {
// We still need to check element expression here because we may need to set appropriate flag on the expression
// such as NodeCheckFlags.LexicalThis on "this"expression.
checkExpression(element);
if (isTupleType(sourceType)) {
error(element, Diagnostics.Tuple_type_0_with_length_1_cannot_be_assigned_to_tuple_with_length_2, typeToString(sourceType), (<TupleType>sourceType).elementTypes.length, elements.length);
}
Expand Down