Repository navigation
Acknowledge draft commands and restore model execution - #495
Merged
Merged
Conversation
Use native eyes reactions on owner command comments without public status comments or model write permissions. Remove the synthetic pre-agent noop that made the first live draft skip model execution, and request completion only after the candidate file exists. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The fix depends on inaccessible pinned gh-aw runtime behavior, and fresh owner-led verification of model execution, detection, and sealing remains outstanding.
No open issues 🎉
What changed in this PR
This PR restores model execution in TypeChat’s owner-requested drafting workflow and adds acknowledgment reactions without publishing status comments or changing draft approval requirements.
Changes:
- Add native
eyesreactions, with reaction-write permissions confined to trusted activation. - Remove the premature completion signal and instruct the model to report completion only after writing the candidate.
- Update regression coverage and owner guidance while preserving scanning, sealing, and publication safeguards.
| File | Description |
|---|---|
tools/tests/discussion-workflows.test.mjs |
Checks acknowledgment, permission boundaries, and completion-signal handling. |
OWNER-CHEATSHEET.md |
Explains acknowledgment reactions and where to check progress. |
AUTOMATION.md |
Documents reaction permissions, the startup failure, and fresh live-verification requirements. |
.github/workflows/discussion-draft.md |
Enables reactions and moves completion signaling after candidate creation. |
.github/workflows/discussion-draft.lock.yml |
Regenerates the workflow with reaction support and corrected completion configuration. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add native eyes reactions to owner draft-command comments and fix the premature completion signal exposed by the first live draft attempt.
Changes
on.reaction: eyesfor Issue and Discussion comment triggers. Keepstatus-comment: false, so acknowledgment does not create a public status comment or publish the proposed response.pull-requests: writeforissue_commentreactions, but TypeChat's owner-only guard still rejects PR comments before activation.noopintroduced in #494. The runtime interprets that output as completed work and skips model execution. Restore the normal no-op allowance and ask the model to emit completion only after writing the candidate file.Live failure evidence
The owner-requested run 41136773812 for #75 logged
noop message found in safe-outputsandskipping agent (work is already complete or no work needed)during model startup. Execution evidence remainednot_started; no candidate or sealed draft was produced. Detection and sealing failed closed, and no response was published.Validation
npm testfromtools)..gitattributesare unchanged; whitespace checks pass.Rollout
No live retry or bot publication was performed. After human review, merge, and post-merge CI, create a new
/typechat draftcomment for verification; rerunning the old failed run reuses its old workflow revision. The eyes reaction is acknowledgment only—not confirmation of a successful draft or acceptance of work.