Use CPAN API for version info rather than HTML parsing#511
Merged
Conversation
gfs
approved these changes
Jul 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The primary purpose of this PR is to fix a failing (integration) test:
CPAN_Download_Version_Succeeds. The test is failing becausemetacpan.orgnow returns Fastly JavaScript which causesCPANProjectManager.EnumerateVersionsAsyncHTML-parsing to fail. This result ofEnumerateVersionsAsyncis used byPackageDownloaderto select the largest version when the specified purl is missing a version.This PR changes
CPANProjectManager.EnumerateVersionsAsyncto obtain the version list fromfastapi.metacpan.org's JSON response (rather than parsing HTML.)This PR also makes a small number of organizational changes:
srcandtestwith corresponding projects under eachShared.Lib.Testsunit testing project, where test organization matches the code under test.CPANMetadataClientclass and adopts a few more modern conventions. The new code hopes for dependency injection one day, prefersCancellationTokenoverHttpClient.Timeout, and usesasyncover.Result.