Fix Windows I2_S linker errors - #606
Open
Ben Younes (ousamabenyounes) wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #595.
Root cause
ggml.creferencesquantize_i2_sanddequantize_row_i2_sfrom theggml-basetarget, but their definitions lived inggml-cpu. Windows linksggml-baseindependently and therefore reported both symbols as unresolved.Fix
Update the llama.cpp submodule to isHuangXin/llama.cpp#5, which moves the unchanged platform-neutral implementations into
ggml-quants.c(ggml-base) and adds a focused executable that links onlyggml-base.Test verification (RED → GREEN)
test-i2-s-linkagefails to link with undefined references toquantize_i2_sanddequantize_row_i2_s.ctest --test-dir build/3rdparty/llama.cpp -R "^test-i2-s-linkage$" --output-on-failure: 1/1 passed.Dependency: isHuangXin/llama.cpp#5