Repository navigation
Allow suppressing all metrics - #2490
Merged
Merged
Conversation
Trask Stalnaker (trask)
marked this pull request as ready for review
September 2, 2022 23:23
Trask Stalnaker (trask)
requested review from
Helen (heyams) and
Jean Bisutti (jeanbisutti)
as code owners
September 2, 2022 23:23
Contributor
|
would it be more convenient to turn off one telemetry kind in one kill-switch config? customers need to indicate which ones to exclude.. if they want all of them, that's lots of exclude or regular expressions. |
Helen (heyams)
approved these changes
Sep 3, 2022
| } | ||
| } | ||
| return false; | ||
| return metricFilters.stream().anyMatch(metricFilter -> metricFilter.exclude(metricName)); |
Contributor
There was a problem hiding this comment.
I have noticed that this method is called from a loop in the AgentMetricExporter class. If the number of iterations could be high, I would prefer to avoid creating a stream at each iteration, to limit heap allocation.
Helen (heyams)
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Allow suppressing all metrics * Remove stream
Helen (heyams)
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Allow suppressing all metrics * Remove stream
Helen (heyams)
pushed a commit
that referenced
this pull request
Sep 16, 2022
* Allow suppressing all metrics * Remove stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1905