Repository navigation
Drop LoggingLevel - #2254
Merged
Merged
Drop LoggingLevel#2254
Conversation
Helen (heyams)
marked this pull request as ready for review
April 29, 2022 23:24
Trask Stalnaker (trask)
left a comment
Member
There was a problem hiding this comment.
let's also add configuration setting to opt-in and preserve existing behavior
Contributor
Author
i thought we're not going to make this opt-in. we will update the doc to introduce this breaking change. function will send loglevel and keeping logginglevel will be more confusing to customers? did i miss something else? |
Trask Stalnaker (trask)
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.