Repository navigation
Send instrumentation and feature as UTF-8 strings for Statsbeat - #1707
Merged
Merged
Conversation
Helen (heyams)
requested review from
kryalama,
Trask Stalnaker (trask) and
Xiao Li (xiao-lix)
as code owners
May 25, 2021 20:30
Trask Stalnaker (trask)
approved these changes
May 25, 2021
Trask Stalnaker (trask)
pushed a commit
that referenced
this pull request
Jun 22, 2021
* Send long as a utf8 string instead of base64 string because kusto doesn't support this * Refactor tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kusto doesn't support converting base64 encoded string back to long.
need to send it as UTF-8 string for instrumentation and feature.