Repository navigation
Truncate exception telemetry's parsedStack when there is a deep stack trace exceeding 65536 bytes - #1702
Merged
Conversation
Helen (heyams)
requested review from
kryalama,
Trask Stalnaker (trask) and
Xiao Li (xiao-lix)
as code owners
May 21, 2021 00:59
Member
|
can you test with an exception that is captured by auto-instrumentation? I think that will go through a different code path and not get fixed by this change |
Contributor
Author
|
Breeze accepts exceptions captured by auto-instrumentation that exceed 65536 bytes. I've sent an email to Oleg to confirm if that's a bug.. because of it's insistent. here clearly indicates that both parsedStack and stack should have the same constraint.. but based on my testing, "stack" doesn't have this constraint. that's why it doesn't have any impact on auto-instrumentation yet. |
Trask Stalnaker (trask)
approved these changes
May 25, 2021
Trask Stalnaker (trask)
approved these changes
May 25, 2021
Contributor
Author
|
Trask Stalnaker (@trask) test:smoke:testApps:WebFlux kept failing.. i reran the job once.. i will let you take a look.. this is keep coming back. |
Trask Stalnaker (trask)
added a commit
that referenced
this pull request
Jun 22, 2021
… trace exceeding 65536 bytes (#1702) * Repro deep stack trace * Truncate parsedStack not to exceed 65536 bytes capacity * Remove test code * cleanup unused imports * Fix javadoc * add note Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com> Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applicationinsights-agent-3.1.1-BETA-SNAPSHOT.zip
2021-05-20 17:44:13.245-07 DEBUG c.m.applicationinsights.agent - ############# current stack depth: 8943
2021-05-20 17:44:13.266-07 DEBUG c.m.a.telemetry.ExceptionTelemetry - parsedStack is exceeding 65536 bytes capacity. It is truncated from full 1024 frames to partial 308 frames.
Trask Stalnaker (@trask) method call depth (8943) does not equal to the number of stack frames (total 1024). What i showed you earlier in Fiddler is the full stack.
When we add stack frame to ExceptionTelemetry, it's already in the reversed order.
Fix #482