py/objdict.c: Implement dictionary union (PEP 584). - #8523
Closed
RayaneCTX wants to merge 1 commit into
Closed
Conversation
RayaneCTX
force-pushed
the
dictionary-union-feature
branch
from
April 12, 2022 00:14
7e67f6b to
d13afdc
Compare
Implements dictionary union according to PEP 584's specifications, minus the fact that dictionary entries are not guaranteed to be in insertion order. However, that will no longer be the case once the underlying map implementation is changed to preserve insertion order (PR#6173). tests/basics/dict_union.py: Add a new set of tests. With the assistance of Fangrui Qin <qinf@purdue.edu> Signed-off-by: Rayane Chatrieux <rayane.chatrieux@gmail.com>
RayaneCTX
force-pushed
the
dictionary-union-feature
branch
from
April 12, 2022 15:10
d13afdc to
3a0ac5e
Compare
Member
|
Thanks for the contribution. I have rebased and merged this in f3e4c50 with a code size optimisation (combined both switch cases) and guarded this feature by MICROPY_CPYTHON_COMPAT (it will be available on most ports/boards). |
tannewt
pushed a commit
to tannewt/circuitpython
that referenced
this pull request
Oct 25, 2023
Fix qrio named_tuple declaration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements dictionary union according to PEP 584 specifications, minus the fact that dictionary entries are not guaranteed to be in insertion order. However, that will no longer be the case once the underlying map implementation is changed to preserve insertion order (see #6173).
A new test is added under tests/basics for this functionality.
This was worked on with the assistance of Fangrui Qin qinf@purdue.edu
Signed-off-by: Rayane Chatrieux rayane.chatrieux@gmail.com