py/objdict: Make OrderedDict.fromkeys return an OrderedDict. - #19645
Open
pablogventura wants to merge 1 commit into
Open
py/objdict: Make OrderedDict.fromkeys return an OrderedDict.#19645pablogventura wants to merge 1 commit into
pablogventura wants to merge 1 commit into
Conversation
Signed-off-by: Pablo Ventura <pablogventura@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19645 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 182 182
Lines 23322 23325 +3
Branches 5 5
=======================================
+ Hits 22993 22996 +3
Misses 328 328
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12011.
dict_fromkeysis a classmethod shared bydictandOrderedDict; it always allocated a plaindict. When called asOrderedDict.fromkeys, setbase.typeandmap.is_orderedon the result (same asmp_obj_dict_make_new).Testing
tests/basics/ordereddict_fromkeys.py(type, insertion order, default value,dict.fromkeysregression)tests/run-tests.py basics/ordereddict_fromkeys.py basics/dict_fromkeys.py basics/dict_fromkeys2.pyon unix portCode size
Unix
standardport,sizetext section (clean rebuild):Only handles
OrderedDictitself (not subclasses), consistent with existing OrderedDict support in MicroPython.Generative AI
I did not use generative AI tools when creating this PR.