tools/mpremote: Fix test_mount.sh - #19604
Open
hmaerki wants to merge 1 commit into
Open
Conversation
hmaerki
force-pushed
the
fix_mpremote_test_mount
branch
from
August 11, 2026 18:33
fd01699 to
8e439bb
Compare
Signed-off-by: Hans Maerki <buhtig.hans.maerki@ergoinfo.ch>
hmaerki
force-pushed
the
fix_mpremote_test_mount
branch
from
August 11, 2026 18:39
8e439bb to
60d69e5
Compare
This was referenced Aug 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19604 +/- ##
==========================================
+ Coverage 98.51% 98.59% +0.07%
==========================================
Files 177 182 +5
Lines 22992 23320 +328
Branches 0 5 +5
==========================================
+ Hits 22651 22992 +341
+ Misses 341 327 -14
- Partials 0 1 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Code size report: |
Octoprobe PR report
Failures |
Josverl
self-requested a review
August 11, 2026 20:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a failure in mpremote/test_mount.sh.
Obverved error
Somehow the line order in
test_mount.sh.expwas out of ordner.Erroronous
test_mount.sh.exp:x y Local directory ${TMP} is mounted at /remoteFixed
test_mount.sh.exp:Local directory ${TMP} is mounted at /remote x yRationale
I assume, this happend in
Where
mountoutputsLocal directory ${TMP} is mounted at /remoteand exec ouputsx y.Setting
export ENV_PYTHONUNBUFFERED=1should write these lines always in sequence.Testing
Tested on linux. But NOT on windows/mac.
Trade-offs and Alternatives
Generative AI
I did not use generative AI tools when creating this PR.