Skip to content

rp2: Fix syntax break in CMakeLists.txt.#19417

Open
Gadgetoid wants to merge 1 commit into
micropython:masterfrom
pimoroni:patch-rp2-bstack-config
Open

rp2: Fix syntax break in CMakeLists.txt.#19417
Gadgetoid wants to merge 1 commit into
micropython:masterfrom
pimoroni:patch-rp2-bstack-config

Conversation

@Gadgetoid

@Gadgetoid Gadgetoid commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Remove backslash escape from the BTStack config file setting. This broke syntax highlighting in VSCode and GitHub's web UI, even though it still worked.

Stumbled upon this while monkeying with PSRAM. It's not essential (doesn't seem to break anything) but reading CMakeLists.txt without syntax highlighting hurts.

See the break in GitHub's web UI half way through:

micropython/ports/rp2/CMakeLists.txt

Lines 349 to 365 in 964803a

if (MICROPY_BLUETOOTH_BTSTACK)
list(APPEND GIT_SUBMODULES lib/btstack)
list(APPEND MICROPY_SOURCE_PORT mpbtstackport.c)
include(${MICROPY_DIR}/extmod/btstack/btstack.cmake)
target_link_libraries(${MICROPY_TARGET} micropy_extmod_btstack)
target_compile_definitions(${MICROPY_TARGET} PRIVATE
MICROPY_BLUETOOTH_BTSTACK=1
MICROPY_BLUETOOTH_BTSTACK_CONFIG_FILE=\"btstack_inc/btstack_config.h\"
)
# For modbluetooth_btstack.c includes
get_target_property(BTSTACK_INCLUDE micropy_extmod_btstack INTERFACE_INCLUDE_DIRECTORIES)
list(APPEND MICROPY_INC_CORE ${BTSTACK_INCLUDE})
endif()

Generative AI

I did not use generative AI tools when creating this PR.

@Gadgetoid
rp2: Fix syntax break in CMakeLists.txt.
3902d77 
rp2/CMakeLists.txt: Remove backslash escape from the BTStack
config file setting. This broke syntax highlighting in VSCode
and GitHub's web UI, even though it still worked.

Signed-off-by: Phil Howard <github@gadgetoid.com>
@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

Code size report:

Reference:  nrf: Restore interrupt-based I2C with nrfx v3. [964803a]
Comparison: rp2: Fix syntax break in CMakeLists.txt. [merge of 3902d77]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
      esp32:    +0 +0.000% ESP32_GENERIC
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Gadgetoid