Skip to content

Apply some more C code formatting#19366

Open
dpgeorge wants to merge 2 commits into
micropython:masterfrom
dpgeorge:more-code-formatting
Open

Apply some more C code formatting#19366
dpgeorge wants to merge 2 commits into
micropython:masterfrom
dpgeorge:more-code-formatting

Conversation

@dpgeorge

@dpgeorge dpgeorge commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary

This updates the PATHS in tools/codeformat.py to include:

  • everything under extmod/
  • everything under py/ (in case one day there are subdirs there...)
  • everything under shared/

This makes sure that any C source files added anywhere under these directories will be formatted (currently only certain subdirs are formatted).

Some files are now included in the C formatting that were not previously, and they are updated in this PR to confirm to the uncrustify code style.

Testing

Tested by CI.

Generative AI

Not used.

dpgeorge added 2 commits June 22, 2026 13:49
@dpgeorge
tools/codeformat.py: Include more C source files in code formatting.
6e9b644 
This updates the PATHS to include:
- everything under `extmod/`
- everything under `py/` (in case one day there are subdirs there...)
- everything under `shared/`

This makes sure that any C source files added anywhere under these
directories will be formatted.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
all: Apply code formatting to new paths.
8a80164 
These need to be formatted due to the parent commit.

Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge dpgeorge requested a review from projectgus June 22, 2026 03:56
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.51%. Comparing base (b49f098) to head (8a80164).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #19366   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files         176      176           
  Lines       22904    22904           
=======================================
  Hits        22563    22563           
  Misses        341      341

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown

Code size report:

Reference:  tools/mpy_ld.py: Allow overriding the internal MPY file name. [b49f098]
Comparison: all: Apply code formatting to new paths. [merge of 8a80164]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
      esp32:    +0 +0.000% ESP32_GENERIC
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

@dpgeorge dpgeorge added extmod Relates to extmod/ directory in source shared Relates to shared/ directory in source labels Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@projectgus projectgus Awaiting requested review from projectgus

Assignees

No one assigned

Labels

extmod Relates to extmod/ directory in source shared Relates to shared/ directory in source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dpgeorge