tests: some tweaks to run/skip on more targets#19335
Open
dpgeorge wants to merge 2 commits into
Open
Conversation
This allows MemoryError to propagate through and skip the test, eg on esp8266 boards. Signed-off-by: Damien George <damien@micropython.org>
Some esp32 boards (eg ESP32_GENERIC_C3) require extra arguments to the SDCard constructor and fail with a ValueError if they aren't provided. Signed-off-by: Damien George <damien@micropython.org>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19335 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 176 176
Lines 22903 22903
=======================================
Hits 22562 22562
Misses 341 341 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Octoprobe PR report
FailuresGroup: run-tests.py --test-dirs=extmod_hardware
Group: run-tests.py
Group: run-tests.py --via-mpy --emit native
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tweak a few tests so they run/skip on more targets (see commit messages for explanations).
Testing
Tested on ESP8266_GENERIC and ESP32_GENERIC_C3, these tests now skip.
Will also be tested by CI and Octoprobe.
Generative AI
Not used.