rp2: use board headers from pico-sdk where possible, and fix filesystem size for variants#19270
Open
dpgeorge wants to merge 9 commits into
Open
rp2: use board headers from pico-sdk where possible, and fix filesystem size for variants#19270dpgeorge wants to merge 9 commits into
dpgeorge wants to merge 9 commits into
Conversation
Fixes: - Flash size is 4MB instead of 2MB. - The default I2C instance is now instance 1 instead of 0. Signed-off-by: Damien George <damien@micropython.org>
Fixes: - Flash size is 16MB instead of 4MB. - Now supports RP2350 A2. Signed-off-by: Damien George <damien@micropython.org>
Fixes: - Flash size is now correct for the given variant. - Filesystem size is adjusted per variant to leave 1MB for application. Signed-off-by: Damien George <damien@micropython.org>
It needs to be defined at the cmake level for the linker scripts. Signed-off-by: Damien George <damien@micropython.org>
It needs to be defined at the cmake level for the linker scripts. Signed-off-by: Damien George <damien@micropython.org>
Fixes the FLASH_16M variant to have 15MB of filesystem space. Signed-off-by: Damien George <damien@micropython.org>
Fixes the FLASH_8M variant to have 7MB of filesystem space. Signed-off-by: Damien George <damien@micropython.org>
Fixes the FLASH_16M variant to have 15MB of filesystem space. Signed-off-by: Damien George <damien@micropython.org>
This was previously a convenience, to have a default flash size. But that leads to more problems than not, eg when the board doesn't use the `pico_cmake_set_default = ...` definition correctly and the flash size is not defined. Then the filesystem gets the incorrect size. So, just require this symbol to be defined at the cmake level. Signed-off-by: Damien George <damien@micropython.org>
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three changes/fixes in this PR:
Testing
Built all boards and all board variants, and manually checked the "Memory region" output. The FLASH and FLASH_FS regions now have the correct sizes.
I didn't test any firmware on boards because I don't have any of the boards that needed changing/fixing.
Generative AI
I did not use generative AI tools when creating this PR.