fix: in py/objboundmeth in objboundmeth.c#19226
Closed
orbisai0security wants to merge 1 commit into
Closed
Conversation
Automated security fix generated by Orbis Security AI
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19226 +/- ##
==========================================
- Coverage 98.47% 98.47% -0.01%
==========================================
Files 176 176
Lines 22845 22847 +2
==========================================
+ Hits 22497 22498 +1
- Misses 348 349 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Code size report: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
py/objboundmeth.c.Vulnerability
V-001py/objboundmeth.c:69Description: In py/objboundmeth.c:69, memcpy copies n_total arguments into the destination buffer args2 without verifying that args2 is large enough to hold all arguments. If n_total is manipulated (e.g., via integer overflow in the size calculation or by passing more arguments than expected), the memcpy writes beyond the allocated buffer boundary, corrupting adjacent heap memory. The same pattern exists in py/objfun.c:446 (n_def_args not validated against o->extra_args allocation size) and py/objnamedtuple.c:117 (n_args not validated against tuple item count).
Changes
py/objboundmeth.cVerification
Automated security fix by OrbisAI Security