Skip to content

nrf: Properly configure asyncio at the makefile level. #19219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dpgeorge wants to merge 3 commits into
base: master
Choose a base branch
from
Open

nrf: Properly configure asyncio at the makefile level. #19219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aeef9c6
py/mpconfig: Enable select.select at the extra feature level.
dpgeorge May 13, 2026
b316ad5
nrf: Properly configure asyncio at the makefile level.
dpgeorge May 13, 2026
fc6638b
nrf: Move manifest.py from modules/ to boards/ directory.
dpgeorge May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ports/nrf/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,14 @@ ifeq ($(DEBUG), 0)
MICROPY_ROM_TEXT_COMPRESSION ?= 1
endif

FROZEN_MANIFEST ?= modules/manifest.py
# Enable asyncio by default and select appropriate manifest.
MICROPY_PY_ASYNCIO ?= 1
ifeq ($(MICROPY_PY_ASYNCIO),1)
FROZEN_MANIFEST ?= boards/manifest.py
else
FROZEN_MANIFEST ?= boards/manifest_minimal.py
endif
CFLAGS += -DMICROPY_PY_ASYNCIO=$(MICROPY_PY_ASYNCIO)

# include py core make definitions
include ../../py/py.mk
Expand Down
2 changes: 1 addition & 1 deletion ports/nrf/boards/ARDUINO_NANO_33_BLE_SENSE/manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
include("$(PORT_DIR)/modules/manifest.py")
include("$(PORT_DIR)/boards/manifest.py")
require("hts221")
require("lps22h")
require("lsm9ds1")
Expand Down
2 changes: 2 additions & 0 deletions ports/nrf/boards/MICROBIT/mpconfigboard.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ else
MICROPY_VFS_LFS2 = 1
endif

MICROPY_PY_ASYNCIO = 0

LD_FILES += boards/nrf51x22_256k_16k.ld
FLASHER = pyocd

Expand Down
0 ports/nrf/modules/manifest.py → ports/nrf/boards/manifest.py
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions ports/nrf/boards/manifest_minimal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
module("_boot.py", base_path="$(PORT_DIR)/modules/scripts", opt=3)
4 changes: 4 additions & 0 deletions ports/nrf/mpconfigport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,10 @@
#define MICROPY_PY_BINASCII (CORE_FEAT)
#endif

#ifndef MICROPY_PY_SELECT
#define MICROPY_PY_SELECT (MICROPY_PY_ASYNCIO)
#endif

#ifndef MICROPY_PY_NRF
#define MICROPY_PY_NRF (CORE_FEAT)
#endif
Expand Down
2 changes: 1 addition & 1 deletion py/mpconfig.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1887,7 +1887,7 @@ typedef time_t mp_timestamp_t;
// implementation). This is present for compatibility but can be disabled to
// save space.
#ifndef MICROPY_PY_SELECT_SELECT
#define MICROPY_PY_SELECT_SELECT (1)
#define MICROPY_PY_SELECT_SELECT (MICROPY_CONFIG_ROM_LEVEL_AT_LEAST_EXTRA_FEATURES)
#endif

// Whether to provide the "time" module
Expand Down
Loading