nrf/boards: Increase stack to 6k for nRF51x22 boards with 32k RAM.#19207
Open
dpgeorge wants to merge 1 commit into
Open
nrf/boards: Increase stack to 6k for nRF51x22 boards with 32k RAM.#19207dpgeorge wants to merge 1 commit into
dpgeorge wants to merge 1 commit into
Conversation
Increase the stack from 4k to 6k for PCA10028 and PCA10031 boards. 4k stack is not much and that causes some tests crash with a stack-overflow exception (eg `extmod/vfs_userfs.py` when run with `--via-mpy`). With the increased stack size there are no longer any tests that fail due to stack overflow on PCA10028. Signed-off-by: Damien George <damien@micropython.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Increase the stack from 4k to 6k for PCA10028 and PCA10031 boards.
4k stack is not much and that causes some tests crash with a stack-overflow exception (eg
extmod/vfs_userfs.pywhen run with--via-mpy). With the increased stack size there are no longer any tests that fail due to stack overflow on PCA10028.Testing
PCA10028 and PCA10031 still build without error.
PCA10028 now passes more tests.
Generative AI
I did not use generative AI tools when creating this PR.