webassembly: support converting buffer protocol objects to Uint8Array in jsffi.to_js()#19142
Open
dpgeorge wants to merge 2 commits into
Open
webassembly: support converting buffer protocol objects to Uint8Array in jsffi.to_js()#19142dpgeorge wants to merge 2 commits into
Uint8Array in jsffi.to_js()#19142dpgeorge wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19142 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 176 176
Lines 22811 22811
=======================================
Hits 22460 22460
Misses 351 351 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If the Python object is a known type (tuple, list, dict) then the caller always wants to follow up with a call to get the associated data for that object. So simplify things to just a single call that gets both the type and object data (if the type is known). Signed-off-by: Damien George <damien@micropython.org>
This adds support for explicit conversion from bytes/bytearray/memoryview
(and other objects with the buffer protocol) to JavaScript `Uint8Array`.
For example:
import js, jsffi
js.console.log(jsffi.to_js(b'1234'))
That now works and prints `Uint8Array[4] [ 49, 50, 51, 52]` in the JS
console. The array contains a copy of the data (ie not a reference).
This matches Pyodide behaviour, eg `pyodide.ffi.to_js(b'1234')` returns the
same `Uint8Array`.
Signed-off-by: Damien George <damien@micropython.org>
353ae4a to
b1af39e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for explicit conversion from bytes/bytearray/memoryview/etc to JavaScript
Uint8Array. Eg:That now works and prints
Uint8Array[4] [ 49, 50, 51, 52]in the JS console. The array contains a copy of the data (ie not a reference).This matches Pyodide behaviour, eg
pyodide.ffi.to_js(b'1234')returns the sameUint8Array.Also includes a clean up of the conversion function to make it more efficient.
Testing
Added a test that runs under CI.
Generative AI
I did not use generative AI tools when creating this PR.