esp32/modnetwork: Enable PHY_GENERIC on ESP32-P4.#19034
Open
sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
Open
esp32/modnetwork: Enable PHY_GENERIC on ESP32-P4.#19034sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
sfe-SparkFro wants to merge 1 commit intomicropython:masterfrom
Conversation
|
Code size report: |
Member
Yes, it looks like it could be. Also, I think the logic to enable |
Also enable MICROPY_PY_NETWORK_LAN if SOC_EMAC_SUPPORTED is defined, which enables on ESP32-P4. Signed-off-by: Dryw Wade <dryw.wade@sparkfun.com>
c1da5f1 to
8e4ea02
Compare
Contributor
Author
Done!
Good catch! Changed it to check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #19033.
Testing
Tested on an ESP32-P4 board.
PHY_GENERICis now available, and works in my testing (can obtain IP address, get data from a website, etc.).Trade-offs and Alternatives
Could
PHY_GENERICjust always be enabled? From what I can tell poking through the ESP-IDF PHY implementations, the all non-generic PHYs do the same initialization (esp_eth_phy_802_3_obj_config_init()) as the generic PHY, plus additional stuff. I don't see why the generic PHY is disabled if the other PHYs are enabled.Generative AI
I did not use generative AI tools when creating this PR.