Skip to content

ports/mimxrt: Add the missing declaration of XBARA1.#18908

Merged
dpgeorge merged 3 commits into
micropython:masterfrom
robert-hh:mimxrt_xbara
Mar 9, 2026
Merged

ports/mimxrt: Add the missing declaration of XBARA1.#18908
dpgeorge merged 3 commits into
micropython:masterfrom
robert-hh:mimxrt_xbara

Conversation

@robert-hh
Copy link
Copy Markdown
Contributor

@robert-hh robert-hh commented Mar 9, 2026 •
edited
Loading

Summary

Add the missing declaration of the symbol XBARA1 for the boards MAKERDIARY_RT1011_NANO_KIT and ADAFRUIT_METRO_M7.

Side change: Remove obsolete WiFi and BLE declarations for ADAFRUIT_METRO_M7.

Testing

Made a test build for both boards, loaded the binaries to the board and verified, that it boots up.

Generative AI

I did not use generative AI tools when creating this PR.

@robert-hh robert-hh mentioned this pull request Mar 9, 2026
Merged
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 9, 2026 •
edited
Loading

Code size report:

Reference:  tests/extmod_hardware/machine_counter.py: Separate the connection test. [2322d37]
Comparison: mimxrt/machine_encoder: Remove executable mode bit. [merge of 41d49b6]
  mpy-cross:    +0 +0.000% 
   bare-arm:    +0 +0.000% 
minimal x86:    +0 +0.000% 
   unix x64:    +0 +0.000% standard
      stm32:    +0 +0.000% PYBV10
      esp32:    +0 +0.000% ESP32_GENERIC
     mimxrt:    +0 +0.000% TEENSY40
        rp2:    +0 +0.000% RPI_PICO_W
       samd:    +0 +0.000% ADAFRUIT_ITSYBITSY_M4_EXPRESS
  qemu rv32:    +0 +0.000% VIRT_RV32

dpgeorge
dpgeorge approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dpgeorge dpgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix. I verified that the two affected boards build.

robert-hh and others added 3 commits March 9, 2026 22:19
@robert-hh @dpgeorge
mimxrt/boards: Add missing declarations of XBARA1 for two boards.
550b68f 
Signed-off-by: robert-hh <robert@hammelrath.com>
@robert-hh @dpgeorge
mimxrt/boards/ADAFRUIT_METRO_M7: Remove unused WiFi/BLE declarations.
6820e22 
Causing a significant increase of the firmware size.

Signed-off-by: robert-hh <robert@hammelrath.com>
@dpgeorge
mimxrt/machine_encoder: Remove executable mode bit.
41d49b6 
Signed-off-by: Damien George <damien@micropython.org>
@dpgeorge
Copy link
Copy Markdown
Member

dpgeorge commented Mar 9, 2026

I also added a commit here to remove the executable mode bit from machine_encoder.c (which I just noticed).

@robert-hh
Copy link
Copy Markdown
Contributor Author

robert-hh commented Mar 9, 2026

Thanks. That happens when files linger around too long while the OS was updated a few times.

@dpgeorge dpgeorge merged commit 41d49b6 into micropython:master Mar 9, 2026
8 checks passed
@robert-hh robert-hh deleted the mimxrt_xbara branch April 28, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpgeorge dpgeorge dpgeorge approved these changes

Assignees

No one assigned

Labels

port-mimxrt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robert-hh @dpgeorge