stm32/spi.c: Use non-DMA transfer for STM32F7 MCUs.#13622
Closed
robert-hh wants to merge 1 commit into
Closed
Conversation
When source and destination are identical, using DMA for SPI transfer fails. See issue micropython#13471. The reason is yet found. This patch uses non-DMA transfer for F7 MCUs, if source and destination are identical. Signed-off-by: robert-hh <robert@hammelrath.com>
Contributor
Author
|
Fixed by #13717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a different patch for issue #13471, changing spi.c. For STM32F7xx MCUs it does not use DMA when source and destination address are identical.
The reason issue #13471 is yet not found. The code seems to set up DMA properly, and sometimes it even works.