Udate architecture diagram.#93
Conversation
28b5750 to
ae07d75
Compare
ralph-lange
left a comment
There was a problem hiding this comment.
Hi @BorjaOuterelo, sorry for reviewing this PR so late. I like the details on rclc that have been added. Very good! Yet, my first visual impression was that the diagram became very complicated. I propose to remove the 3D effect completely or to reduce the depth of the boxes to a minimum. Also, in my diagram, I put the rcl extensions on the same layer as rcl to express more clearly that we basically use rcl as C API and do not create a completely new C API.
|
@ralph-lange thanks for the review. Already addressed your comment on clarity by:
The C API I have made the box of rcl to reach from one end to the other on the Client library. I want to state also that most of the rcl extensions use that same rcl. |
|
Hi @BorjaOuterelo, the diagram looks much better now. The coloring is a very good idea! I propose to place micro-ROS rclc inside the orange C API shape. Otherwise a reader might think that we want to provide three APIs (rcl, rclc, rclcpp). |
|
@ralph-lange I added your API susggestion. It seems more clear now. Right? |
|
Should/may we already add FreeRTOS in the diagram? |
|
I added it. It messes a bit the RTOS part, but it states that we have support for both, NuttX and FreeRTOS. |
* Udate architecture diagram. * Change architecture shapes and colors. * Improve client library API diagram. * Add FreeRTOS.
Update architecture diagram to follow same theme and use concepts from decision paper.